Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-HTML-QuickForm - Class for creating, validating, processing HTML forms Alias: pear-HTML-QuickForm https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212912 ------- Additional Comments From Fedora@xxxxxxxxxxxxxxxxx 2006-11-12 04:17 EST ------- == TEST == No test suite provided. Samples works well. == REVIEW == * source files match upstream: 7d3cbe961e17996641abec79c953e3dd HTML_QuickForm-3.2.7.tgz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license (PHP) * license is open source-compatible. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development). * package installs properly * rpmlint is silent. * final provides and requires are sane: php-pear(Pager) = 2.4.2 php-pear-Pager = 2.4.2-1.fc6 * %check is not present; see comment * owns the directories it creates (HTML owned by HTML_Common which is required) * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (pear install) * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. Should, as usualy : - bundle PHP Licence in %doc (perhaps change %{pear_name}-%{version}/docdir/%{pear_name}/docs/* to %{pear_name}-%{version}/docdir/%{pear_name}/docs is a good idea) - add versioned requires for php-pear(HTML_Common) >= 1.2.1 APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review