Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609738 --- Comment #7 from Kalev Lember <kalev@xxxxxxxxxxxx> 2010-07-24 10:57:25 EDT --- (In reply to comment #6) > shiboken-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libshiboken.so.0.3.2 > exit@xxxxxxxxxxx > This library package calls exit() or _exit(), probably in a non-fork() > context. Doing so from a library is strongly discouraged - when a library > function calls exit(), it prevents the calling program from handling the > error, reporting it to the user, closing files properly, and cleaning up any > state that the program has. It is preferred for the library to return an > actual error code and let the calling program decide how to handle the > situation. > > 5 packages and 0 specfiles checked; 0 errors, 10 warnings. > > Spelling errors can be ignored. > Not shure what to make of shared-lib-calls-exit, but it doesn't look good. I suspect rpmlint is just being stupid. libshiboken/typeresolver.cpp:70 contains the following line which probably triggers the rpmlint error: std::atexit(deinitTypeResolver); This is something all together different than calling exit() directly. > in %files > %{_libdir}/generatorrunner/* <-- add generatorrunner as R generatorrunner is already an implicit dependency: $ rpm -q --requires shiboken | grep gen libgenrunner.so.0.5 $ rpm -qf /usr/lib/libgenrunner.so.0.5 generatorrunner-0.5.0-2.fc14.i686 But yeah, I guess it's cleaner to also explicitly list generatorrunner dep. > ? SHOULD: Usually, subpackages other than devel should require the base package > using a fully versioned dependency. > > Add Requires: %{name} = %{version}-%{release} to %package libs No, it's the other way around in here: the main package has Requires: %{name}-libs = %{version}-%{release} The reason why libs are in a separate package is to avoid pulling in the whole shiboken main package (plus its long dep chain) for libraries which link against libshiboken; requiring main package from libs package would make the split meaningless. * Sat Jul 24 2010 Kalev Lember <kalev@xxxxxxxxxxxx> - 0.3.2-4 - Explicitly require generatorrunner for %%{_libdir}/generatorrunner/ directory ownership (#609738) Spec URL: http://kalev.fedorapeople.org/shiboken.spec SRPM URL: http://kalev.fedorapeople.org/shiboken-0.3.2-4.fc14.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2348167 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review