[Bug 617141] Review Request: gupnp-dlna - A collection of helpers for building DLNA applications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=617141

Bruce Cowan <bugs@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugs@xxxxxxxxxxxx

--- Comment #1 from Bruce Cowan <bugs@xxxxxxxxxxxx> 2010-07-24 07:09:19 EDT ---
Very informal review:

The -docs package contains files that should be in -devel.

The BuildRoot tag is no longer required, so

BuildRoot:     %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

and

rm -rf %{buildroot}

can be removed.

The -vala package should require vala, not vala-devel. Also, I don't think
vala-tools is required.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]