[Bug 207472] Review Request: ruby-activesupport - Utility classes and extension to Ruby's standard library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ruby-activesupport - Utility classes and extension to Ruby's standard library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207472


tibbs@xxxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs@xxxxxxxxxxx  2006-11-12 01:13 EST -------
Sorry for taking so long to get back; I'm just getting back up to speed.

I admit to not understanding fully why rpmlint complains so stridently about
files with shebang lines that aren't executable.  I can understanding a warning
so that you double check that you haven't installed a script and forgotten to
make it executable, but these aren't supposed to be executable, and patching
them out just seems like needless specfile complexity and diversion from
upstream for absolutely no gain.

In the past such things have been fixed up by the packager, but I've never felt
good about that and frankly I'm ready to stop asking folks to change it.  I
don't think it's ever been considered an absolute blocker in any case.

The changes yoou made look good to me, and the package builds fine.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]