Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=575529 Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cwickert@xxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |cwickert@xxxxxxxxxxxxxxxxx --- Comment #15 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2010-07-22 19:25:52 EDT --- (In reply to comment #5) > In fact, you were right in using $RPM_BUILD_ROOT%{_datadir}/xsessions/ as PATH > for the desktop file, but it still _must_ be installed using > desktop-file-install. No, this rule only applies to desktop files that create menu entries. We have other desktop files for xsession entries, xfce4-panel plugins, kde services and many more. These are not necessarily flowing the freedesktop specs and thus cannot be installed with desktop-file-utils. This means that the desktop file is ok for this package. But there is another problem: Quoting from http://dwm.suckless.org/ Because dwm is customized through editing its source code, it’s pointless to make binary packages of it. This keeps its userbase small and elitist. No novices asking stupid questions. There are some distributions that provide binary packages though. Damien, are you sure you want to package this? If you are willing to maintain this, I'll go ahead and do an official review, but IMHO you really should think about this twice. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review