Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xfce4-dict-plugin - A XFCE panel plugin to query a Dict server https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215169 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-11-11 22:26 EST ------- Here's a review: OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: ac2f3626858b7b6800ac43cc9de6e0bc xfce4-dict-plugin-0.2.0.tar.bz2 ac2f3626858b7b6800ac43cc9de6e0bc xfce4-dict-plugin-0.2.0.tar.bz2.1 OK - BuildRequires correct OK - Spec handles locales/find_lang See below - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane: SHOULD Items: OK - Should build in mock. x86_64/i386 - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version Issues: 1. Should add a: %defattr(-,root,root,-) to files? 2. Should the BuildRequire for xfce4-panel-devel 4.3.99.1 be 4.3.99.2, since everything else is requiring that version? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review