Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=603666 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |603639 --- Comment #1 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-07-22 11:29:48 EDT --- Review: Good: - name ok - source match upstream: 95f50ded72ebc5f77a9063b41820929c - no libs - buildarch noarch - no locales - no *.la - license ok Needswork: - Development/Tools would be better as group - %files: Please be a bit more explicit like in your other packages. (It seems you just forgot it here) - %{version} should be in url - Missing R fonttools and python-appkit and python-ufo2fdk - This one again seems to not install right: $ rpmls noarch/python-defconAppKit-0.1-1.fc13.noarch.rpm drwxr-xr-x /usr/lib/python2.6/site-packages/defconAppKit -rw-r--r-- /usr/lib/python2.6/site-packages/defconAppKit-0.1-py2.6.egg-info -rw-r--r-- /usr/lib/python2.6/site-packages/defconAppKit/__init__.py -rw-r--r-- /usr/lib/python2.6/site-packages/defconAppKit/__init__.pyc -rw-r--r-- /usr/lib/python2.6/site-packages/defconAppKit/__init__.pyo drwxr-xr-x /usr/share/doc/python-defconAppKit-0.1 -rw-r--r-- /usr/share/doc/python-defconAppKit-0.1/License.txt Don't know, what's the problem here... There should be more subfolders in defconAppKit - Where is Foundation module? ./Lib/defconAppKit/controls/fontInfoView.py:from Foundation import * Maybe another missing dependency. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review