Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=616983 --- Comment #4 from Xavier Bachelot <xavier@xxxxxxxxxxxx> 2010-07-22 05:51:55 EDT --- More comments : - License is actually GPL+, sorry for my earlier misleading comment. http://fedoraproject.org/wiki/Licensing - Use the most compressed source, here .tar.bz2 rather than.tar.gz https://fedoraproject.org/wiki/Packaging:SourceURL - Use parallel make when building. https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make - Missing BuildRequires: gettext. https://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files - Missing BuildRequires: desktop-file-utils. https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage - According to desktop-file-validate, the desktop file has a few issues : yarssr.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated yarssr.desktop: warning: value "Application;Network;" for key "Categories" in group "Desktop Entry" contains a deprecated value "Application" yarssr.desktop: error: value "text/html" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character - The package must not own %{_datadir}/applications, only the desktop file. - %defattr is not correct. https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions - The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. - When submitting a package for review, you need to provide the spec file and the source rpm, not the binary rpm. http://fedoraproject.org/wiki/Package_Review_Process#Contributor - You must add a changelog entry and bump the release tag accordingly every time you submit a modified version of your package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review