Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609130 --- Comment #9 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> 2010-07-21 09:29:27 EDT --- (In reply to comment #7) > (In reply to comment #2) > > In case you will be doing more releases...please change BRs from > > maven2-plugin-XX to maven-XX-plugin. New plugins provide old names, but it > > would be better to get rid of old names and not introduce them in new > > packages. > OK, but now > # yum --disablerepo=* --enablerepo=rawhide install maven-surefire-plugin > maven-bundle-plugin > Loaded plugins: presto, refresh-packagekit > Setting up Install Process > No package maven-surefire-plugin available. > No package maven-bundle-plugin available. > > Hence, I'll add to the spec something like this: > # TODO check availability and use new names > #BuildRequires: maven-surefire-plugin > #BuildRequires: maven-bundle-plugin > # instead of > BuildRequires: maven2-plugin-surefire > BuildRequires: maven-plugin-bundle You are almost correct. maven-bundle-plugin hasn't been updated yet and maven-surefire-plugin is currently maven-surefire-maven-plugin (I'll fix this by the end of the week). So yes, those BRs are fine now. > > Was it necessary to remove tests? Simple -Dmaven.test.skip=true > > wouldn't work? You commented on this so it's perfectly fine to remove > > them...just wondering. > The tests are compiled with errors without the rat-maven-plugin that is not in > Fedora yet. That's exactly why "-Dmaven.test.skip" is there. The tests won't be even compiled with this option. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review