[Bug 581220] Review Request: qtsingleapplication - Qt library to start applications only once per user

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581220

--- Comment #23 from Kalev Lember <kalev@xxxxxxxxxxxx> 2010-07-21 06:59:48 EDT ---
I agree with Orcan: qtsinglecoreapplication.h file only contains function
prototypes and to use these the program certainly needs to be linked with the
actual DSO providing the symbols.

(In reply to comment #22)
> LIBS *= -lQtSolutions_SingleCoreApplication-2.6

I must say I don't like the symlink name
libQtSolutions_SingleCoreApplication-2.6.so, but at least it's consistent with
the non-Core library naming and we should follow upstream naming even if we
think it's bad. Upstream should really get their act together and name it to
something like:
libQtSingleCoreApplication.so (symlink)
libQtSingleCoreApplication.so.2 (soname)
libQtSingleCoreApplication.so.2.6.1 (DSO)
instead. Right now the .prf files hide these names from apps which use qmake,
but apps which use other build systems need to spell out the whole name (which
includes version!) to link with the lib.

The way Orcan is proposing the split in comment #22 is in my opinion the best
we can do here.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]