[Bug 581220] Review Request: qtsingleapplication - Qt library to start applications only once per user

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581220

Christophe Dumez <dchris@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dchris@xxxxxxxxx
               Flag|                            |needinfo?

--- Comment #21 from Christophe Dumez <dchris@xxxxxxxxx> 2010-07-20 16:47:48 EDT ---
I think there may be an issue for programs using QtCore but not QtGui.

The qtsingleapplication solution provides both QtCore and QtGui classes, for
example, QtSingleApplication and QtSingleCoreApplication.

According to the examples provided by Nokia for qtsingleapplication, only the
programs using the QtSingleApplication class need to link against the so file,
the programs using only QtSingleCoreApplication don't.

The issue is that your qtsingleapplication-devel package only provide
qtsingleapplication.prf, no qtsinglecoreapplication.prf file.

qtsinglecoreapplication.prf file would contain only:
INCLUDEPATH *= $$QMAKE_INCDIR_QT/QtSolutions
DEPENDPATH  *= $$QMAKE_INCDIR_QT/QtSolutions
QT *= network

instead of:
INCLUDEPATH *= $$QMAKE_INCDIR_QT/QtSolutions
DEPENDPATH  *= $$QMAKE_INCDIR_QT/QtSolutions
LIBS *= -lQtSolutions_SingleApplication-2.6
QT *= network

I believe Programs that don't use QtGui should not depend on the
qtsingleapplication package (which provides the so file) because it requires
QtGui.

What do you think about this?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]