Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615809 --- Comment #2 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> 2010-07-20 08:21:49 EDT --- Before I start official review....The package name should not include version of the specification. I know we talked about this before...but if you look at other geronimo-XXX packages present in fedora (for example geronimo-jms) you can see they don't use spec version in names. In case we will ever need to have two different specs present we can "fix" naming later, but it's better to be consistent (reminds me of http://www.despair.com/consistency.html)... With this naming change there is also Provides that is not so great IMO: > Provides: annotation_1_0_api = %{version}-%{release} That provides can be skipped entirely, you already have annotation_api Provides. Otherwise package seems pretty good to me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review