Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=616289 --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2010-07-20 05:42:45 EDT --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2330110 + rpmlint is silent for SRPM and for RPM. perl-MooseX-Clone.noarch: W: spelling-error %description -l en_US barebones -> bare bones, bare-bones, barytones perl-MooseX-Clone.src: W: spelling-error %description -l en_US barebones -> bare bones, bare-bones, barytones perl-MooseX-Clone.src: W: no-cleaning-of-buildroot %clean perl-MooseX-Clone.src: W: no-buildroot-tag perl-MooseX-Clone.src: W: no-%clean-section 2 packages and 0 specfiles checked; 0 errors, 5 warnings. ==> Ok for this package + source files match upstream url (sha1sum) 690f80e1b8d9c1106acfc3b186d242ffbec18956 MooseX-Clone-0.05.tar.gz 690f80e1b8d9c1106acfc3b186d242ffbec18956 MooseX-Clone-0.05.tar.gz.srpm + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present which is not needed now. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=2, Tests=32, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.48 cusr 0.02 csys = 0.53 CPU) + Package perl-MooseX-Clone-0.05-1.fc14.noarch => Provides: perl(MooseX::Clone) = 0.05 perl(MooseX::Clone::Meta::Attribute::Trait::Clone) perl(MooseX::Clone::Meta::Attribute::Trait::Clone::Base) perl(MooseX::Clone::Meta::Attribute::Trait::Clone::Std) perl(MooseX::Clone::Meta::Attribute::Trait::Copy) perl(MooseX::Clone::Meta::Attribute::Trait::NoClone) perl(MooseX::Clone::Meta::Attribute::Trait::StrableClone) Requires: perl(Carp) perl(Hash::Util::FieldHash::Compat) perl(Moose::Role) perl(MooseX::Clone::Meta::Attribute::Trait::Clone) perl(MooseX::Clone::Meta::Attribute::Trait::Copy) perl(MooseX::Clone::Meta::Attribute::Trait::NoClone) perl(MooseX::Clone::Meta::Attribute::Trait::StorableClone) perl(namespace::clean) rpmlib(VersionedDependencies) <= 3.0.3-1 + Not a GUI application I think those Requires that are same as provides should be filtered? when I local built this on F13 and tried to install I got Error: Package: perl-MooseX-Clone-0.05-1.fc13.noarch (/perl-MooseX-Clone-0.05-1.fc13.noarch) Requires: perl(MooseX::Clone::Meta::Attribute::Trait::StorableClone) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review