Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506425 --- Comment #28 from manuel wolfshant <wolfy@xxxxxxxxxxxxxxxxxx> 2010-07-20 04:51:21 EDT --- Aleksey, this is the third and last time that I ask you to increase the release tag EACH time you modify the spec. Now, a couple of corrections which are needed: - cron scripts placed in /etc/cron.d do not follow the format specified in man 5 crontab; they have an additional field which specifies the user which the script runs as. Since you have decided to not use the lightsquid user, you MUST use another user instead. - the folder /usr/share/lightsquid (attention, I mean just the folder, not its content) is already owned by the main lightsquid package; please do not include it in lightsquid-apache, too. - do not delete the existing files from /report. If the admin wants to delete them, he can do that. But with your existing %post, you nuke all the history at each install, including at updates - what do you use the group created in %pre ? I see no file being installed as group lightsquid. - "%{__rm} -rf %{SOURCE1}.redhat" is useless. First of all because it's in the buildroot which gets deleted anyway and second (this does not apply if you will branch the package for EPEL) because cleaning the buildroot is no longer needed by the new Fedora build process. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review