Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563822 Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #2 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2010-07-19 17:57:01 EDT --- No blockers. Two minor things to consider: - rpmlint can be ignored: globus-gram-job-manager-setup-sge.src: W: invalid-url Source0: globus_gram_job_manager_setup_sge-2.5.tar.gz ! The files AUTHORS and CREDITS can be added to the package. ! We don't need to bundle the file GLOBUS_LICENSE in the tarball since LICENSE.GTPL is the same. But it is probably included by your scripts. No big deal. - Package builds fine in F-13, rawhide. Good to go. -------------------------------------------------------------------- This package (globus-gram-job-manager-setup-sge) is APPROVED by oget -------------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review