Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226562 --- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> 2010-07-19 12:00:05 EDT --- 1)rpmlint reported xkeyboard-config.src:45: E: use-of-RPM_SOURCE_DIR ===>you use $RPM_SOURCE_DIR or %{_sourcedir} in your spec file. If you have to use a directory for building, use $RPM_BUILD_ROOT instead. xkeyboard-config.src: W: patch-not-applied Patch2: 0001-Add-Euro-and-New-Shekel-sign-to-israeli-layout.patch xkeyboard-config.src: W: patch-not-applied Patch3: 0001-symbols-de-remove-BKSP-from-neo-layout.patch xkeyboard-config.src: W: patch-not-applied Patch4: 0001-Remove-duplicate-BKSL-key-mappings-from-hin-wx-layou.patch ==>here patch is applied in different way, so ignore this xkeyboard-config.noarch: W: no-documentation 2)timestamps should be preserved.Use INSTALL="install -p" when installing to preserve timestamps. 3)Should use https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make 4) I will suggest this pacakge to follow current packaging guidelines and remove buildroot, %clean section and cleaning of build root in %install -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review