Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226646 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx, | |peter.hutterer@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2010-07-19 10:37:01 EDT --- 1) rpmlint on SRPM and RPM reported xorg-x11-util-macros.src: W: spelling-error Summary(en_US) Autotools -> Auto tools, Auto-tools, Autopilots xorg-x11-util-macros.src: W: spelling-error %description -l en_US autotools -> auto tools, auto-tools, autopilots xorg-x11-util-macros.noarch: E: explicit-lib-dependency libtool xorg-x11-util-macros.noarch: W: spelling-error Summary(en_US) Autotools -> Auto tools, Auto-tools, Autopilots xorg-x11-util-macros.noarch: W: spelling-error %description -l en_US autotools -> auto tools, auto-tools, autopilots xorg-x11-util-macros.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/xorg-macros.pc 2 packages and 0 specfiles checked; 1 errors, 5 warnings. 2) I will suggest this package to follow current packaging guidelines and remove buildroot, %clean section and cleaning of build root in %install. But this is not blocker for this review. 3) But reviewguildlines also says MUST: Each package must consistently use macros. [16] so this package should use macros. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review