Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226023 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tomspur@xxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tomspur@xxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-07-19 07:32:06 EDT --- review: GOOD: - name ok - license ok - locales properly handled - libs correctly installed - no *.la NEEDSWORK - python subpackage does not require the mainpackage nor contains own COPYING* files. You can choose between the two possibilities. For more info see: http://lists.fedoraproject.org/pipermail/devel-announce/2010-July/000631.html - $ rpmlint ./libgsf-1.14.18-2.fc13.src.rpm ./x86_64/libgsf-* libgsf.src: W: spelling-error %description -l en_US eg -> Eg, eh, e libgsf.x86_64: W: spelling-error %description -l en_US eg -> Eg, eh, e libgsf-devel.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/gsf-vba-dump ['/usr/lib64'] libgsf-devel.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/gsf ['/usr/lib64'] libgsf-gnome.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libgsf-gnome-1.so.114.0.18 ['/usr/lib64'] libgsf-gnome.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/gsf-office-thumbnailer ['/usr/lib64'] libgsf-gnome.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/gsf-office-thumbnailer.schemas libgsf-gnome-devel.x86_64: W: no-documentation libgsf-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.6/site-packages/gsf/gnomemodule.so gnomemodule.so()(64bit) libgsf-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.6/site-packages/gsf/_gsfmodule.so _gsfmodule.so()(64bit) libgsf-python.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/python2.6/site-packages/gsf/gnomemodule.so ['/usr/lib64'] libgsf-python.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/python2.6/site-packages/gsf/_gsfmodule.so ['/usr/lib64'] libgsf-python.x86_64: W: no-documentation 7 packages and 0 specfiles checked; 6 errors, 7 warnings. See: https://fedoraproject.org/wiki/Packaging/Guidelines#Removing_Rpath - I needed to use 'rm -rf $RPM_BUILD_ROOT' and not just 'rm -r' in %clean, or the build fails for me. - Please use this macro from: https://fedoraproject.org/wiki/Packaging:Python %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} %endif And not your own defined python_py_sitearch and python_lib_sitearch. - Please use INSTALL="install -p" when installing to preserve timestamps. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review