Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485652 --- Comment #66 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2010-07-19 05:07:18 EDT --- Ok. summarizing of what should be done: * Interestingly, it fails to build on F-14 but builds fine on F-13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2328357 (F-14) http://koji.fedoraproject.org/koji/taskinfo?taskID=2328369 (F-13) This must be fixed. * rpmlint isn't silent: work ~/Desktop: rpmlint navit-* navit.i686: W: spelling-error %description -l en_US gpsd -> gypsy, Gypsy, gypsum navit.i686: W: incoherent-version-in-changelog 0.1.2-0.2.20090918svn2578 ['0.1.2-0.3.20100521svn3291.fc13', '0.1.2-0.3.20100521svn3291'] navit.i686: W: no-manual-page-for-binary navit navit.i686: W: no-manual-page-for-binary maptool navit-graphics-qt.i686: W: spelling-error %description -l en_US xml -> XML, cml, ml navit-graphics-qt.i686: W: no-documentation navit-graphics-sdl.i686: W: spelling-error %description -l en_US xml -> XML, cml, ml navit-graphics-sdl.i686: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 8 warnings. work ~/Desktop: Don't forget to add proper %%changelog entry for every src.rpm version bump. All other messages should be discarded * The package contains *.la files. Please, remove them. * You dont use parallel make - please, add note, that this package can't be build with parallel make or enable it. *. I advice you to provide README.Fedora as the Source{X}, instead of creating it in spec. Since it doesn't contain mutable parts (such as %{libdir}), then no need to create every rebuild (this also reduces size of spec to review). Not a blocker - feel free to reject/ignore this particular advice. * The package doesn't own /etc/navit dir. * Please, add the following files as %doc: COPYING COPYRIGHT GPL-2 LGPL-2 * navit still contains large parts from some packages, available in Fedora. Please, remove them before building (at %prep stage). Namely: 'navit/support' directory is full of duplicated libraries. 'navit/map/shapefile' contains parts of shapelib 'navit/map/poi_geodownload' contains mdbtools it also contains librafy for operations with fibonnaci numbers under 'navit/fib-1.1' directory, but it seems that it wasn't included in Fedora yet, so it's safe to keep it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review