Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gaim-libnotify - libnotify notification plugin for gaim https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211834 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-11-11 09:57 EST ------- Well, first review for this package: 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : * Use rpmlint * Changelogs Rpmlint says: -------------------------------------------- W: gaim-libnotify no-version-in-last-changelog -------------------------------------------- Add the specific version to Changelog. For example: * Mon Oct 23 2006 Jon Nettleton <jon.nettleton@xxxxxxxxx> - 0.12-2 - Fixiup spec file for acceptance into Extras * BuildRequires - libtool This is not required for BuildRequires. I can rebuild this by mockbuild without libtool. 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : = Nothing. Fix the issues above. --------------------------------------------- NOTE: Before being sponsored: This package will be accepted with another few work. But before I accept this package, someone (I am a candidate) should sponsor you. Once you are sponsored, you have the right to formally review other submitters' review request and approve the packages. For this reason, the person who want to be sponsored (like you) are required to "show that you have an understanding of the process and of the packaging guidelines". Usually there are two ways to show this. A. submit other review requests with enough quality. B. Do a "pre-review" (at the time you are not sponsored, you cannot do a formal review) of other person's review request. Please check the details on http://fedoraproject.org/wiki/Extras/HowToGetSponsored ----------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review