Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593800 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #18 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-07-18 15:37:21 EDT --- Some notes: * Macro definition - For defining %python_sitearch macro and so on, please follow below: https://fedoraproject.org/wiki/Packaging/Python#Macros * Filtering Provides - If you want to filter some Provides generated by rpmbuild, you can now use "%filter_provides_in" macro as defined in /usr/lib/rpm/redhat/macro (in redhat-rpm-config rpm): https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Preventing_files.2Fdirectories_from_being_scanned_for_provides_.28pre-scan_filtering.29 ! Note that current way of yours does not work as you expected, see: http://koji.fedoraproject.org/koji/taskinfo?taskID=2327705 http://koji.fedoraproject.org/koji/getfile?taskID=2327705&name=build.log * Release number - Please use <integer>%{?dist} for Release number (expect for some exceptions) (2%{?dist}, for example). * BuildRoot - BuildRoot tag is now no longer used on Fedora so please remove this. ! Note: - If you want to import this package also into EPEL, please follow: https://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#Distribution_specific_guidelines * python-devel BuildRequires: - Now please explicitly specify python2-devel or python3-devel for (Build)Requires: https://fedoraproject.org/wiki/Packaging/Python#BuildRequires * KDE BuildRequires - This packge uses Qt4, so only KDE4 should be needed. Please write "BR: kdelibs4-devel" only and remove "BR: kdelibs3-devel". ! Note - Unfortunately, it seems that the needed "libkdeui.so" (for -lkdeui) is under %_libdir/kde4/devel (in kdelibs-devel), so you have to add "export LDFLAGS=-L%{_libdir}/kde/devel" or something else before "python setup.py build". * %defattr - We usually use %defattr(-,root,root,-) for default %defattr * Directory ownership issue - The directory %{python_sitelib}/%{upstream_name}/ itself is not owned by any packages. * python_sitelib v.s. python_sitearch ------------------------------------------------------------------------- 24 # Actually the main package is noarch but -gnome and -kwallet contain ------------------------------------------------------------------------- - Well, however on x86_64 files in even main package are also installed under %python_sitearch: http://koji.fedoraproject.org/koji/taskinfo?taskID=2327573 * rpmlint issue ------------------------------------------------------------------------- python-keyring.src: W: strange-permission keyring-0.2.tar.gz 0777L python-keyring.src: W: strange-permission python-keyring.spec 0777L ------------------------------------------------------------------------- - Please change the permission of the files in srpm to 0644. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review