Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469931 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo? | --- Comment #37 from Hans de Goede <hdegoede@xxxxxxxxxx> 2010-07-18 05:52:16 EDT --- Hi Andy, Thanks for the new version. This time it builds. So now I've been able to run rpmlint. rpmlint has found some minor issues once those are fixed I'll approve this package and sponsor you. First a bunch of rpmlint false-positives for the sake of completeness. ipmiutil.src: W: spelling-error %description -l en_US metacommand -> meta command, meta-command, Metacom ipmiutil.src: W: spelling-error %description -l en_US subcommand -> sub command, sub-command, subcommander ipmiutil.src: W: spelling-error %description -l en_US dev -> dec, deb, de ipmiutil.src: W: spelling-error %description -l en_US ipmi -> impi ipmiutil.src: W: spelling-error %description -l en_US imb -> ib, mb, iamb ipmiutil.x86_64: W: spelling-error %description -l en_US metacommand -> meta command, meta-command, Metacom ipmiutil.x86_64: W: spelling-error %description -l en_US subcommand -> sub command, sub-command, subcommander ipmiutil.x86_64: W: spelling-error %description -l en_US dev -> dec, deb, de ipmiutil.x86_64: W: spelling-error %description -l en_US ipmi -> impi ipmiutil.x86_64: W: spelling-error %description -l en_US imb -> ib, mb, iamb ipmiutil.x86_64: W: service-default-enabled /etc/rc.d/init.d/ipmi_port Then some real (although very minor) issues: ipmiutil.src:125: W: mixed-use-of-spaces-and-tabs (spaces: line 106, tab: line 125) ipmiutil.x86_64: W: spurious-executable-perm /usr/share/doc/ipmiutil-2.6.7/ChangeLog ipmiutil.x86_64: E: wrong-script-end-of-line-encoding /usr/share/doc/ipmiutil-2.6.7/ChangeLog ipmiutil.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/ipmiutil-2.6.7/README ipmiutil.x86_64: W: spurious-executable-perm /usr/share/doc/ipmiutil-2.6.7/UserGuide ipmiutil.x86_64: E: wrong-script-end-of-line-encoding /usr/share/doc/ipmiutil-2.6.7/UserGuide ipmiutil.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/ipmiutil-2.6.7/TODO ipmiutil.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/ipmiutil-2.6.7/COPYING ipmiutil.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/ipmiutil-2.6.7/AUTHORS The mixed-use-of-spaces-and-tabs thingie speaks for itself, as for the others, the usual way to fix this is to do the following in %setup: chmod -x foo bar sed -i 's/\r//' foo bar But given that you are upstream, you could of course also fix these in the tarbal :) Regards, Hans -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review