Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597888 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mschwendt@xxxxxxxxx --- Comment #5 from Michael Schwendt <mschwendt@xxxxxxxxx> 2010-07-18 04:44:00 EDT --- > Requires: gtk2 >= 2.14 > Requires: gstreamer >= 0.10.17 > Requires: gstreamer-plugins-base >= 0.10.17 > Requires: gstreamer-plugins-good >= 0.10.17 Be aware of the following guideline: https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires Dependency on gtk2 and gstreamer library SONAMEs is automatic already. The explicit versions are much lower than what is available with Fedora. And gstreamer-plugins-good requires gstreamer-plugins-base. So, you should reduce these explicit Requires to just gstreamer-plugins-good with a comment that this app strictly needs this collection of plugins. > %install > rm -rf %{buildroot} > %clean > rm -rf %{buildroot} Since you also omitted the BuildRoot definition, you could drop further stuff: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review