[Bug 591192] Review Request: dh-make - Tool that converts source archives into Debian package source

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591192

--- Comment #3 from Jeroen van Meeuwen <kanarip@xxxxxxxxxxx> 2010-07-17 07:26:35 EDT ---
I probably packaged a previous version because that was the most recent version
available at the time.(In reply to comment #1)

> This should be fixed:
> 
> $ rpmlint /home/msuchy/rpmbuild/SRPMS/dh-make-0.46-1.el6.src.rpm
> dh-make.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 1)
> 

Fixed.

> $ rpmlint /home/msuchy/rpmbuild/RPMS/noarch/dh-make-0.46-1.el6.noarch.rpm
> dh-make.noarch: E: devel-dependency dpkg-devel
>    This should be safe to ignore, but if you did not make review yet I would
> maybe suggest to keep Debian original name dpkg-dev

The dpkg package is in Fedora already, and cannot be changed just like that.

> dh-make.noarch: E: zero-length /usr/share/doc/dh-make-0.46/examples

Fixed.

> dh-make.noarch: E: non-executable-script
> /usr/share/debhelper/dh_make/debian/postinst.ex 0644L /bin/sh
> dh-make.noarch: E: non-executable-script
> /usr/share/debhelper/dh_make/debian/postrm.ex 0644L /bin/sh
> dh-make.noarch: E: non-executable-script
> /usr/share/debhelper/dh_make/debian/emacsen-remove.ex 0644L /bin/sh
> dh-make.noarch: E: non-executable-script
> /usr/share/debhelper/dh_make/debian/prerm.ex 0644L /bin/sh
> dh-make.noarch: E: non-executable-script
> /usr/share/debhelper/dh_make/debian/preinst.ex 0644L /bin/sh
> dh-make.noarch: E: non-executable-script
> /usr/share/debhelper/dh_make/debian/emacsen-install.ex 0644L /bin/sh
> dh-make.noarch: E: non-executable-script
> /usr/share/debhelper/dh_make/debian/init.d.lsb.ex 0644L /bin/sh
> 

Fixed.

> dh-make.noarch: W: spurious-executable-perm /usr/share/doc/dh-make-0.46/rules
> Is there reason why init.d.ex is executable and othes not?    

Some files have a shebang, others do not.

New SPEC:
http://git.ergo-project.org/?p=kolab-fedora.git;a=blob_plain;f=f12/custom-f12-buildsys/SPECS/dh-make.spec
New SRPM:
http://koji.ergo-project.org/packages/dh-make/0.46/2.fc12.buildsys/src/dh-make-0.46-2.fc12.buildsys.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]