Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515752 --- Comment #22 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> 2010-07-16 13:39:15 EDT --- Apologies! I misread Comment 16 as the modified tarball still being in the package. I see now that it's been fixed. About putting the defines for hash and compression algorithm in the spec file. the issue there is that that causes the package to use those algorithms no matter what the build is targeted at. On Fedora and EPEL-6, we wouldn't want this to occur as the newer hash is more secure and the newer compression is much smaller. The build system will do the right thing without the defines when building from the vcs (as it will construct the srpm using the correct defines for that target). All packagers who build srpms on Fedora and target EL-5 need to be aware of this issue anyway although they may not be aware of the fix. So a comment may be appropriate but is not strictly necessary... perhaps better documentation in the wiki would make this better although where in the wiki it would be found is an open question in my mind. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review