Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615319 --- Comment #2 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2010-07-16 13:15:46 EDT --- Review: + OK ? ISSUES - NA -------------------------------------------------------------------------------- + Package meets naming and packaging guidelines + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. ? License ? License field in spec matches + License file included in package + Spec in American English + Spec is legible. + Sources match upstream md5sum: [Ankur@localhost rpmbuild]$ md5sum cgnslib_2.5-4.tar.gz SOURCES/cgnslib_2.5-4.tar.gz 42063efdf726c81300a51c3495d3224e cgnslib_2.5-4.tar.gz 42063efdf726c81300a51c3495d3224e SOURCES/cgnslib_2.5-4.tar.gz - Package needs ExcludeArch + BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. + Package has a correct %clean section. + Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) + Package is code or permissible content. - Doc subpackage needed/used. + Packages %doc files don't affect runtime. + Headers/static libs in -devel subpackage. + Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig + .so files in -devel subpackage. + -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. ? No rpmlint output. SHOULD Items: + Should build in mock. Checked koji -> http://koji.fedoraproject.org/koji/taskinfo?taskID=2324518 + Should build on all supported archs ? Should function as described. + Should have sane scriptlets. + Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version - check for outstanding bugs on package. (For core merge reviews) Issues: 1.Haven't been able to run rpmlint yet. Mock giving dep errors. Will run it whenever possible and comment 2.Not checked functioning 3.License looks like zlib. Why the LGPL? "This license is borrowed from the zlib/libpng License: http://www.opensource.org/licenses/zlib-license.php and supercedes the GNU Lesser General Public License (LGPL) which previously governed the use and distribution of the software." -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review