Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=614653 --- Comment #5 from Kalev Lember <kalev@xxxxxxxxxxxx> 2010-07-16 10:36:45 EDT --- You have added doxygen and graphviz as BuildRequires to build docs, but the generated docs don't appear in the final rpms. Why? > %exclude %{_mandir}/man3/Xcm.3x.gz Please add a comment to the spec file why this file is removed. > %description > The library allows to attach color regions to windows for color management. Take a look at the included README file which has a slightly more elaborate description, perhaps you can use something from that. The installed /usr/include/X11/Xcm.h includes <X11/Xlib.h> and <X11/Xatom.h>, which means that the -devel package needs to depend on the packages which provide the headers: libX11-devel and xorg-x11-proto-devel. > %{_includedir}/* This glob also makes the package own /usr/include/X11/ directory, but it looks like that the convention so far has been to have xorg-x11-proto-devel own the dir and the rest of the libX*-devel packages just depend on xorg-x11-proto-devel. I would not suggest to depend on xorg-x11-proto-devel solely for /usr/include/X11 directory ownership, but since this package already gets pulled in to solve header deps, it's better for libXcm-devel to not own this dir. So, in summary, I'd suggest to add libX11-devel and xorg-x11-proto-devel to -devel Requires, and use %{_includedir}/X11/Xcm.h instead of the glob above. Please address the issues mentioned here and I'll evaluate the package for final approval. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review