Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=611066 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2010-07-16 03:31:27 EDT --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2323514 + rpmlint is silent for SRPM and for RPM. + source files match upstream url (sha1sum) 6a6d82747fbddb575f9729eb891ffbe8ab793123 B-Compiling-0.02.tar.gz 6a6d82747fbddb575f9729eb891ffbe8ab793123 B-Compiling-0.02.tar.gz.srpm + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present which is not needed now + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=2, Tests=5, 1 wallclock secs ( 0.01 usr 0.02 sys + 0.06 cusr 0.02 csys = 0.11 CPU) + Package perl-B-Compiling-0.02-1.fc14.x86_64 => Provides: perl(B::Compiling) = 0.02 Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) perl(B) perl(strict) perl(Sub::Exporter) perl(warnings) perl(XSLoader) rpmlib(VersionedDependencies) <= 3.0.3-1 rtld(GNU_HASH) + Not a GUI application Suggestions If package is imported for F-13 and above then please follow 1) buildroot should be removed 2) %clean not needed 3) cleaning of buildroot at start of %install also not needed APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review