Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=611069 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2010-07-16 03:31:17 EDT --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2323517 + rpmlint output for SRPM and for RPM. perl-Devel-Declare.src: W: spelling-error %description -l en_US declarators -> declaratory, declarations, declaration ==> can be ignored + source files match upstream url (sha1sum) 4a18a944fb12bc6459230d214a00e04e46a11c85 Devel-Declare-0.006000.tar.gz 4a18a944fb12bc6459230d214a00e04e46a11c85 Devel-Declare-0.006000.tar.gz.srpm + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=24, Tests=99, 1 wallclock secs ( 0.07 usr 0.03 sys + 0.71 cusr 0.11 csys = 0.92 CPU) + Package perl-Devel-Declare-0.006000-1.fc14.x86_64 => Provides: perl(Devel::Declare) = 0.006000 perl(Devel::Declare::Context::Simple) perl(Devel::Declare::MethodInstaller::Simple) = 0.006000 Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) perl >= 0:5.008001 perl(base) perl(B::Hooks::EndOfScope) perl(B::Hooks::OP::Check) perl(Carp) perl(constant) perl(Devel::Declare) perl(Scalar::Util) perl(strict) perl(Sub::Name) perl(vars) perl(warnings) rpmlib(VersionedDependencies) <= 3.0.3-1 rtld(GNU_HASH) + Not a GUI application Suggestions: If package is imported for F-13 and above then please follow 1) buildroot should be removed 2) %clean not needed 3) cleaning of buildroot at start of %install also not needed You also don't need BuildRequires: perl >= 1:5.8.1 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review