Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=614836 --- Comment #4 from chris.spike@xxxxxxxx 2010-07-15 12:37:34 EDT --- (In reply to comment #2) > Other notes: > * You are skipping tests. If they compile fine (and to me it seems > they do, it's usually better to just > -Dmaven.test.failure.ignore=true. This way tests are run, you can see > the output and build doesn't fail when tests fail. Fixed > * Might be a good idea and try those tests with upstream maven. They > usually succeed, but if they fail with upstream -> file bugs Tests run fine with upstream maven > * IMPORTANT: > You are missing provides/obsoletes for > maven2-plugin-checkstyle. See other maven-X-plugin packages spec files. Even if it's a new plugin? Should I do it for rmic-maven-plugin, too? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review