Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502686 Patrick Monnerat <pm@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|denis.arnaud_fedora@xxxxxxx |pm@xxxxxxxxxxxxx Flag| |fedora-review+ --- Comment #17 from Patrick Monnerat <pm@xxxxxxxxxxxxx> 2010-07-15 11:39:27 EDT --- rpmlint output: wsdlpull.spec: W: no-buildroot-tag wsdlpull.src: W: spelling-error %description -l en_US serializer -> serialize, serializes, serialized wsdlpull.src: W: no-buildroot-tag wsdlpull.x86_64: W: spelling-error %description -l en_US serializer -> serialize, serializes, serialized wsdlpull.x86_64: W: shared-lib-calls-exit /usr/lib64/libxmlpull.so.1.0.23 exit@xxxxxxxxxxx wsdlpull-devel.x86_64: W: no-documentation 5 packages and 1 specfiles checked; 0 errors, 6 warnings. Can be safely ignored. (the exit call in the code is not a packaging problem: I suggest you talk with upstream about possible removal and/or replacement). Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2321987 Review: OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK source files match upstream: wsdlpull-1.23.tar.bz2 sha1: 7b61549e18bf0e9aae68bfb76264f6e58c8a8d7b md5: 68ba60913b5860cae1a07ee8ccdd43cf OK summary is OK. OK description is OK. OK dist tag is present. OK build root is OK. OK license field matches all the actual licenses. OK license is open source-compatible. OK license text included in package. OK All BuildRequires are needed. OK %clean is present. OK The package meets the Packaging Guidelines. OK package builds in Koji (rawhide). OK package installs properly. OK rpmlint is OK OK final provides and requires are sane: rpm -q --provides -p wsdlpull-1.23-3.fc12.x86_64.rpm libschema.so.1()(64bit) libwsdl.so.1()(64bit) libxmlpull.so.1()(64bit) wsdlpull = 1.23-3.fc12 wsdlpull(x86-64) = 1.23-3.fc12 rpm -q --requires -p wsdlpull-1.23-3.fc12.x86_64.rpm /sbin/ldconfig /sbin/ldconfig libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libcurl.so.4()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.2.5)(64bit) libschema.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.11)(64bit) libstdc++.so.6(GLIBCXX_3.4.9)(64bit) libwsdl.so.1()(64bit) libxmlpull.so.1()(64bit) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH) rpmlib(PayloadIsXz) <= 5.2-1 rpm -q --provides -p wsdlpull-devel-1.23-3.fc12.x86_64.rpm wsdlpull-devel = 1.23-3.fc12 wsdlpull-devel(x86-64) = 1.23-3.fc12 rpm -q --requires -p wsdlpull-devel-1.23-3.fc12.x86_64.rpm libschema.so.1()(64bit) libwsdl.so.1()(64bit) libxmlpull.so.1()(64bit) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 wsdlpull = 1.23-3.fc12 rpmlib(PayloadIsXz) <= 5.2-1 rpm -q --provides -p wsdlpull-doc-1.23-3.fc12.noarch.rpm wsdlpull-doc = 1.23-3.fc12 rpm -q --requires -p wsdlpull-doc-1.23-3.fc12.noarch.rpm rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 OK %check is not present; no test suite upstream. OK shared libraries are added to the regular linker search paths: ldconfig properly called in %post and %postun OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK code and allowed content. OK There is a separate -doc subpackage for the documentation. OK %docs are not necessary for the proper functioning of the package. OK headers are in the -devel subpackage. OK no pkgconfig files. OK no static libraries. OK no libtool .la files. OK filenames are all valid UTF-8. SHOULD: All patches should have an upstream bug link or comment Why don't you simply leave them at http://sourceforge.net/tracker/?group_id=96736&atid=615730 and reference patch reports here ? Package approved -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review