Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=612174 Mattias Ellert <mattias.ellert@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mattias.ellert@xxxxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Mattias Ellert <mattias.ellert@xxxxxxxxxxxx> 2010-07-15 06:38:24 EDT --- (In reply to comment #0) > * eurephia.spec:75: E: use-of-RPM_SOURCE_DIR > One OpenVPN specific file (openvpn-plugin.h) needs to be added extra. I've > just included that file as a plain text file and does a 'cp' into the source > tree. I'm using cp %{_sourcedir}/openvpn-plugin.h to grab the file. If there > is a better way how to do this, I'm willing to move to that solution. In the > future I hope this requirement will go away, as I've asked the OpenVPN package > maintainer to include openvpn-plugin.h in the openvpn package. cp %{SOURCE1} . One more comment: Your %setup unpacks the sources twice: + cd /home/ellert/rpmbuild/BUILD + rm -rf eurephia-1.0.0 + /usr/bin/bzip2 -dc /home/ellert/rpmbuild/SOURCES/eurephia-1.0.0.tar.bz2 + /bin/tar -xf - + STATUS=0 + '[' 0 -ne 0 ']' + /usr/bin/bzip2 -dc /home/ellert/rpmbuild/SOURCES/eurephia-1.0.0.tar.bz2 + /bin/tar -xf - + STATUS=0 + '[' 0 -ne 0 ']' + cd eurephia-1.0.0 If you are using the -b (or -a) flag to %setup you should also use the -T flag to prevent the default setup invocation. But -b0 is the default so instead of adding -T you could instead simply drop the -b0. %prep %setup -q -n %{name}-%{version}%{?betatag:_%{betatag}} %patch0 -p1 # This is needed to ship extra until openvpn-plugin.h becomes part of the OpenVPN RPM cp %{SOURCE1} . -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review