Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=611033 Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #6 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2010-07-14 17:41:25 EDT --- (In reply to comment #3) > brief explanation for addnl sources > something like where the file comes from and why it is for. The brief comment in the last specfile seems good. > 2) NYA (might not be needed?): "BRs: libevent-devel [...] procps seem > redundant." procps is used in the build tests, in particular. > I can build the package, and the tests don't fail when I remove procps from BR. Am I missing something? Anyway, it small package and this is not a blocker. By the way there was something like "BuildRequires(check):" for such purposes. > 3) NYA: rpmlint warnings on installed hail pkg, related to [un]linked > libraries these are okay. Thanks for the updates. I built the package on F-13 and on rawhide without problems. The package is good to go. --------------------------------------- This package (hail) is APPROVED by oget --------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review