Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502686 --- Comment #15 from Denis Arnaud <denis.arnaud_fedora@xxxxxxx> 2010-07-14 04:32:10 EDT --- (In reply to comment #13) > http://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment > This is not mandatory, but you planned to submit patches upstream and you > forgot to do it. I suggest you do it now and insert the links to the upstream > patch reports in your comments. Yes, of course, I knew that one :) I'll keep upstream (Vivek Krishna) updated, and include the corresponding references within the specification file. > From comment 6: > > You should use xargs option -r in > > find . -name 'CVS' -print | xargs rm -rf > > find . -name 'a.out' -print | xargs rm -f > > in prevision of future versions not containing the targets. > > You did not apply this change. Any reason for that ? Sorry for that. I did not understand it the first time: I thought you were referring to the -r option of the rm command, not of the xargs command... I now understand that that GNU extension to xargs is pretty useful when there is no CVS directory or a.out file. > > I've left the %doc in the -devel sub-package, though. > Please read > http://lists.fedoraproject.org/pipermail/devel/2010-July/138487.html and > http://fedoraproject.org/wiki/Packaging:Guidelines#Duplicate_Files Yes, I knew both items above. But duplicating files is tolerated... and prevents rpmlint from issuing the following warning: wsdlpull-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. So, I removed the duplicated documentation files, and the warning is back. But it has no importance, hasn't it? .../... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review