Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592670 Douglas Schilling Landgraf <dougsland@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dougsland@xxxxxxxxxx --- Comment #21 from Douglas Schilling Landgraf <dougsland@xxxxxxxxxx> 2010-07-13 17:53:44 EDT --- Hello Rafael, Comments, inline. > Ralf Corsepius 2010-05-19 09:31:16 EDT > >> " Mongoose supports SSL but does not depend on the SSL library. >> This is because SSL support is best-effort: Mongoose tries to load libssl.so >> dynamically. >> If it is present on the system, Mongoose will support SSL, otherwise not. > >That's not the way to do it under Linux. The normal way to use shared libs is >to directly link them in. > >If, for some reasons, they need to be dlopen'ed, then the "versioned libraries" >libraries need to be dlopen'ed, not the unversioned libraries. > >I.e. dlopening libopenssl.so is wrong. >It should be libopenssl.so.<something> => This package needs to be patched. > >BTW: I just noticed, in mongoose, the same consideration applies to >libcrypto.so.*. IMO, your spec looks good, also followed all requests above. However, since using the approach for versioning the libssl as described early, please also add RequireBuild field for openssl package, and make a script in order to check dynamically the correct version of ssl library. Using this can avoid break the package (since currently is static - 1.0.0) for future release on Fedora. Thanks! Cheers Douglas -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review