Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=609506 Shakthi Kannan <shakthimaan@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #5 from Shakthi Kannan <shakthimaan@xxxxxxxxx> 2010-07-13 13:12:57 EDT --- Here is the review: Legend: +: ok NA: not applicable MUST Items: [+] MUST: rpmlint output $ rpmlint gtk2hs-buildtools.spec ../RPMS/i686/gtk2hs-buildtools-0.9-2.fc14.i686.rpm ../SRPMS/gtk2hs-buildtools-0.9-2.fc14.src.rpm gtk2hs-buildtools.i686: W: spelling-error Summary(en_US) Haskell -> Harrell, Rathskeller, Hastily gtk2hs-buildtools.i686: W: spelling-error %description -l en_US hs -> HS, sh, gs gtk2hs-buildtools.i686: W: spelling-error %description -l en_US gtk -> gt, gt k, GTE gtk2hs-buildtools.i686: W: no-manual-page-for-binary gtk2hsHookGenerator gtk2hs-buildtools.i686: W: no-manual-page-for-binary gtk2hsTypeGen gtk2hs-buildtools.i686: W: no-manual-page-for-binary gtk2hsC2hs gtk2hs-buildtools.src: W: spelling-error Summary(en_US) Haskell -> Harrell, Rathskeller, Hastily gtk2hs-buildtools.src: W: spelling-error %description -l en_US hs -> HS, sh, gs gtk2hs-buildtools.src: W: spelling-error %description -l en_US gtk -> gt, gt k, GTE 2 packages and 1 specfiles checked; 0 errors, 9 warnings. [+] MUST: Package Naming Guidelines [+] MUST: spec file name must match base package %{name} [+] MUST: Packaging Guidelines. [+] MUST: Licensing Guidelines [+] MUST: License field in the package spec file must match actual license. [+] MUST: include license files in %doc if available in source [+] MUST: The spec file must be written in American English and be legible. [+] MUST: source md5sum matches upstream release 9cbc63d222b518e378e5a42769ce59d1 gtk2hs-buildtools-0.9.tar.gz [+] MUST: must successfully compile and build into binary rpms on one main arch [NA] MUST: if necessary use ExcludeArch for other archs [+] MUST: All build dependencies must be listed in BuildRequires [NA] MUST: use %find_lang macro for .po translations [NA] MUST: packages which store shared library files in the dynamic linker's default paths, must call ldconfig in %post and %postun. [NA] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review [+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [+] MUST: A package must not contain any duplicate files in the %files listing. [+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. [+] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [+] MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines. [+] MUST: The package must contain code, or permissable content. [NA] MUST: Large documentation files should go in a doc subpackage. [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [NA] MUST: Header files must be in a -devel package. [NA] MUST: Static libraries must be in a -static package. [NA] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} [NA] MUST: Packages must NOT contain any .la libtool archives, these should be removed in the spec. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [+] MUST: All filenames in rpm packages must be valid UTF-8. SHOULD Items: [+] SHOULD: The reviewer should test that the package builds in mock. [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. F-13, F-14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2316862 http://koji.fedoraproject.org/koji/taskinfo?taskID=2316865 [+] SHOULD: The reviewer should test that the package functions as described. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. Package APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review