Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=612023 --- Comment #9 from Chen Lei <supercyper1@xxxxxxxxx> 2010-07-13 12:15:47 EDT --- (In reply to comment #8) > The package looks OK now. Since %makeinstall usually should not be used, please > add a short comment telling that it's valid here and works without unwanted > side-effects. > I also recommend to be more specific in the %files section to avoid packaging > of unwanted files in future versions, e.g. > %{_includedir}/*.h instead of %{_includedir}/* > Actually, tinycdb only has one head file - cdb.h, will be fixed in cvs. > $ rpmlint /var/lib/mock/fedora-13-x86_64/result/*.rpm > tinycdb.src: W: no-buildroot-tag > 4 packages and 0 specfiles checked; 0 errors, 1 warnings. > > If you don't plan to build this package for EPEL, the warning can be ignored. > Otherwise, add a buildroot tag and clean the buildroot in %install. > Additionally, Requires: pkgconfig would be necessary. > Requires: pkgconfig will be added by rpmbuild automatically now, thanks for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review