Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=612023 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #8 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-07-13 12:02:28 EDT --- The package looks OK now. Since %makeinstall usually should not be used, please add a short comment telling that it's valid here and works without unwanted side-effects. I also recommend to be more specific in the %files section to avoid packaging of unwanted files in future versions, e.g. %{_includedir}/*.h instead of %{_includedir}/* $ rpmlint /var/lib/mock/fedora-13-x86_64/result/*.rpm tinycdb.src: W: no-buildroot-tag 4 packages and 0 specfiles checked; 0 errors, 1 warnings. If you don't plan to build this package for EPEL, the warning can be ignored. Otherwise, add a buildroot tag and clean the buildroot in %install. Additionally, Requires: pkgconfig would be necessary. --------------------------------- Key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: %makeinstall must not be used when make install DESTDIR=%{buildroot} works. - make install DESTDIR=%{buildroot} doesn't work - %makeinstall has no unwanted side-effects here, and simplifies the installation process [+] MUST: The package must be licensed with a Fedora approved license. [+] MUST: The License field in the package spec file must match the actual license. [.] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum tinycdb_0.77.tar.gz* c00e5fb96c30356ac3b67b2ab5d5641b tinycdb_0.77.tar.gz c00e5fb96c30356ac3b67b2ab5d5641b tinycdb_0.77.tar.gz.1 [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. koji scratch builds: F-12: http://koji.fedoraproject.org/koji/taskinfo?taskID=2316672 F-13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2316685 [.] MUST: If the package does not successfully compile, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. [+] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [+] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. - static library removed [+] MUST: Library files with a suffix (e.g. libfoo.so.1.1) must go in a -devel package. [+] MUST: devel packages must require the base package using a fully versioned dependency [+] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) ... [+] SHOULD: The reviewer should test that the package builds in mock. [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [+] SHOULD: The reviewer should test that the package functions as described. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [+] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [+] SHOULD: your package should contain man pages for binaries/scripts. ---------------- Package APPROVED ---------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review