Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530747 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andy.shevchenko@xxxxxxxxx --- Comment #9 from Andy Shevchenko <andy.shevchenko@xxxxxxxxx> 2010-07-13 08:43:34 EDT --- I add few comments about spec file from a src.rpm mentioned in comment #5: - it's better to have two binary packages (why should I have client installed on server side?) - indentation in the spec is a bit inconsistency: there are few parameters which have not enough TABs - there is new version 0.6.0-rc1 - line '#% configure' looks redundant - I prefer to see explicit names in the %files section for files under %{_sbindir}, because the binaries in such package might be changed - for me the '-c' option in the CFLAGS is odd, I guess the patch of Makefile could fix the oddness P.S. What is the actual status of this package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review