Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=612719 --- Comment #10 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2010-07-13 07:48:48 EDT --- hi, I got this from -devel >I think it would be best to talk to upstream of this project and > see if there is any chance of them upstreaming any of their patches for > these projects. If not, then getting to admit that they are forking > them and only using them internally would at least be good to know. It looks like it's okay. Formal review coming up! + OK ? ISSUE - NA ================================================================================= + Package meets naming and packaging guidelines + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. + Sources match upstream md5sum: [Ankur@localhost rpmbuild]$ md5sum recoll-1.13.04.tar.gz SOURCES/recoll-1.13.04.tar.gz eba9d639dbac149996a92b9b2dffc5ee recoll-1.13.04.tar.gz eba9d639dbac149996a92b9b2dffc5ee SOURCES/recoll-1.13.04.tar.gz - Package needs ExcludeArch + BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. + Package has a correct %clean section. + Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) + Package is code or permissible content. - Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. + Package is a GUI app and has a .desktop file ? Package compiles and builds on at least one arch. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. - No rpmlint output. - final provides and requires are sane: (include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done manually indented after checking each line. I also remove the rpmlib junk and anything provided by glibc.) SHOULD Items: ? Should build in mock. ? Should build on all supported archs ? Should function as described. + Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version - check for outstanding bugs on package. (For core merge reviews) Issues: 1. I wasn't able to build it for rawhide. You'll have to correct this, since the first branch you'll build in will be *rawhide*. 2. I haven't been able to build it correctly, and so haven't tested it's working. No rpmlint output on the spec and the source. A few issues, but should be small enough to quickly be solved. Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review