Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=613879 --- Comment #1 from Chen Lei <supercyper1@xxxxxxxxx> 2010-07-13 05:14:10 EDT --- Initial comments here: 1.rpmlint fill*rpm fillmore.src: W: spelling-error Summary(en_US) multitrack -> multitask, multiracial, multitude fillmore.src: W: spelling-error %description -l en_US multitrack -> multitask, multiracial, multitude fillmore.src: W: non-standard-group Unspecified fillmore.src:33: W: configure-without-libdir-spec fillmore.src: W: no-cleaning-of-buildroot %clean fillmore.src: W: no-buildroot-tag fillmore.src: W: no-%clean-section fillmore.x86_64: W: spelling-error Summary(en_US) multitrack -> multitask, multiracial, multitude fillmore.x86_64: W: spelling-error %description -l en_US multitrack -> multitask, multiracial, multitude fillmore.x86_64: W: non-standard-group Unspecified fillmore.x86_64: W: no-manual-page-for-binary fillmore fillmore.x86_64: E: invalid-desktopfile /usr/share/applications/fillmore.desktop value "application/fillmore;text/yorba-media" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character fillmore-lombard.x86_64: W: non-standard-group Unspecified fillmore-lombard.x86_64: W: no-manual-page-for-binary lombard fillmore-lombard.x86_64: E: invalid-desktopfile /usr/share/applications/lombard.desktop value "application/lombard;text/yorba-media" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character 4 packages and 0 specfiles checked; 2 errors, 13 warnings. invalid-desktopfile errors and non-standard-group Unspecified warnings should be fixed. 2. Missing mimeinfo scripts in spec https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo 3. Package name don't match naming guideline: fillmore can be renamed to fillmore-lombard, then create to two independent subpackages, fillmore and lombard are two seperate softwares. %package -n fillmore %package -n lombard 4. Spec don't honor compiler flags(%{optflags}) correctly >From koji log: cc -c `pkg-config --cflags gee-1.0 gdk-x11-2.0 gstreamer-0.10 gstreamer-base-0.10 gstreamer-controller-0.10 gstreamer-interfaces-0.10 gstreamer-pbutils-0.10 gtk+-2.0` -I../../vapi -D_VERSION='"0.1.0"' -D_PREFIX='"/usr"' -O2 -g -pipe -fPIC -o marina/ui_clip.o marina/ui_clip.c -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review