Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=612533 --- Comment #7 from Parag AN(पराग) <panemade@xxxxxxxxx> 2010-07-13 00:43:43 EDT --- 1)rpmlint when run on above package gives a)qrencode.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/qrencode ['/usr/lib64'] The binary or shared library defines `RPATH'. Usually this is a bad thing because it hardcodes the path to search libraries and so makes it difficult to move libraries around. Most likely you will find a Makefile with a line like: gcc test.o -o test -Wl,--rpath. Also, sometimes configure scripts provide a --disable-rpath flag to avoid this. => sed commands should be run after %configure and then make command. But this way tests are failing. So, I think we can use last approach given at http://fedoraproject.org/wiki/Packaging/Guidelines#Removing_Rpath and instead of adding sed commands in %build, you can add following at the end of %install commands. chrpath --delete $RPM_BUILD_ROOT%{_bindir}/qrencode b)qrencode.x86_64: E: library-without-ldconfig-postin /usr/lib64/libqrencode.so.3.1.1 This package contains a library and provides no %post scriptlet containing a call to ldconfig. qrencode.x86_64: E: library-without-ldconfig-postun /usr/lib64/libqrencode.so.3.1.1 This package contains a library and provides no %postun scriptlet containing a call to ldconfig. ==> When package contains libraries you need to use http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries Use following %post -p /sbin/ldconfig %postun -p /sbin/ldconfig 2) If you have plan to build this only for devel branch then you can remove BuildRoot tag, %clean section and cleaning of buildroot in %install See http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review