Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=604331 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #3 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-07-12 13:43:13 EDT --- Some notes: * License - As far as I checked the whole source code, the license tag should be "GPLv3+". * BuildRoot - BuildRoot tag is no longer needed on Fedora: https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag ! Note that on EPEL5 and below BuildRoot tag is still needed. * Naming of gtk subpackage - Normally Fedora names gui related subpackage as "%{name}-gui" or "%{name}-gtk", and the former (-gui) is more general if no other gui backend (such as qt or so) is provided. * Python related (Build)Requires - Currently your srpm won't build on Fedora 12 because of lacking %python_sitelib definition. Please refer to: https://fedoraproject.org/wiki/Packaging/Python#Macros - Please use "python2" or "python3" for (Build)Requires, c.f. https://fedoraproject.org/wiki/Packaging/Python#BuildRequires * Dependencies between subpackages - Usually dependencies between binary rpms rebuilt from the same srpm must be EVR(Epoch-Version-Release) specific: https://fedoraproject.org/wiki/Packaging/Guidelines#Requiring_Base_Package * Make build.log more verbose - Currently build.log does not show how linkage on the created binary is done: ------------------------------------------------------ 183 CCLD redshift 184 make[3]: Leaving directory `/builddir/build/BUILD/redshift-1.4.1/src' 185 make[2]: Leaving directory `/builddir/build/BUILD/redshift-1.4.1/src' ------------------------------------------------------ Please add "V=1" to "make %{?_smp_mflags}". * Timestamp - Please consider to use ------------------------------------------------------ make DESTDIR=%{buildroot} install INSTALL="install -p" ------------------------------------------------------ to keep timestamps on the installed files as much as possible. This method usually works for Makefiles generated by recent autotools. * Desktop file - When gui program is installed, the corresponding desktop file must be properly installed: https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review