Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502686 --- Comment #13 from Patrick Monnerat <pm@xxxxxxxxxxxxx> 2010-07-12 07:00:55 EDT --- Some more things: http://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment This is not mandatory, but you planned to submit patches upstream and you forgot to do it. I suggest you do it now and insert the links to the upstream patch reports in your comments. >From comment 6: > You should use xargs option -r in > find . -name 'CVS' -print | xargs rm -rf > find . -name 'a.out' -print | xargs rm -f > in prevision of future versions not containing the targets. You did not apply this change. Any reason for that ? > I've left the %doc in the -devel sub-package, though. Please read http://lists.fedoraproject.org/pipermail/devel/2010-July/138487.html and http://fedoraproject.org/wiki/Packaging:Guidelines#Duplicate_Files Buildroot is no longer needed: http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag You can save the "BuildRequires: dos2unix" by replacing the call to dos2unix by sed -i -e 's/\r$//' -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review