Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: beneath-a-steel-sky-cd - Beneath a Steel Sky - Adventure Game - CD version Alias: scummvm-bass-CD https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214091 chris.stone@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From chris.stone@xxxxxxxxx 2006-11-09 17:58 EST ------- ==== REVIEW CHECKLIST ==== - rpmlint output W: beneath-a-steel-sky-cd no-%build-section okay, but no harm in enabling %build either - spec file named according to package naming guidelines (but a provides bass-cd would make it easier to install) - spec filename matches %{name} - package meets packaging guidelines - licensed as distributable, see https://www.redhat.com/archives/fedora-extras-list/2006-November/msg00030.html - License file included in %doc - spec written in American english - spec file is legible - sources match upstream 1d4401cd663715332abe8bb5431e356d bass-cd-1.2.zip - package successfully compiles and builds on FC5 X86_64 - all dependencies listed in BR - no locales - no shared libraries - package is not relocatable - package owns all directories it creates - no duplicates in %files - file permissions set properly - package has proper %clean section - macro usage is consistent - package contains permissible content - no large documentation - no header files or static libraries - no pkgconfig files - no devel subpackage required - no .la files - package contains proper .desktop file - package does not own files or directories owned by other packages APPROVED ==== SHOULD ==== - uncomment %build to make rpmlint happy - add Provides: bass-cd for easier commandline installs - add comment above license pointing to distribution discussions on f-e-l -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review