Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476056 --- Comment #12 from Michel Alexandre Salim <michael.silvanus@xxxxxxxxx> 2010-07-11 16:08:28 EDT --- Only two minor changes needed: - untabify line 24 - mark documentation files as %doc See below for details: #+TODO: TODO(t) WAIT(w@/!) FAIL(f@) | DONE(d) N/A(n) * TODO Review [87%] ** DONE Names [2/2] *** DONE Package name *** DONE Spec name ** DONE Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]] ** DONE source files match upstream sha1sum: 7b6d46976bd56496d0715c4e150b85c924658b60 ** DONE License [3/3] *** DONE License is Fedora-approved *** DONE License field accurate *** DONE License included iff packaged by upstream ** DONE rpmlint [2/2] *** DONE on src.rpm minor glitch: gnustep-back.src:24: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 24) if using Emacs, C-x h M-x untabify would convert all tabs to spaces *** DONE on x86_64.rpm $ rpmlint ~/Downloads/gnustep-back* 2 packages and 0 specfiles checked; 0 errors, 0 warnings. ** DONE Language & locale [3/3] *** DONE Spec in US English *** DONE Spec legible *** N/A Use %find_lang to handle locale files ** DONE Build [3/3] *** DONE Koji results http://koji.fedoraproject.org/koji/taskinfo?taskID=2311879 *** DONE BRs complete *** DONE Directory ownership ** TODO Spec inspection [7/8] *** N/A ldconfig for libraries *** DONE No duplicate files *** DONE File permissions *** DONE Filenames must be UTF-8 *** DONE Has %clean section (except F-13+: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean) *** DONE %buildroot cleaned on %install *** DONE Macro usage consistent *** TODO Documentation [2/3] **** N/A If large docs, separate -doc **** DONE %doc files are non-essential **** FAIL Documentation files tagged %doc - State "FAIL" from "TODO" [2010-07-11 Sun 22:06] \\ %{_datadir}/GNUstep/Documentation/Developer/Back/ should be marked as such -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review