Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569492 --- Comment #11 from Ankur Sinha <sanjay.ankur@xxxxxxxxx> 2010-07-11 14:05:47 EDT --- I just noticed that you need a sponsor, so I can't officially review this one, sorry. here's an **INFORMAL** review (since I promised). It'll make the package better and easier for a sponsor to review. She/he will have to do it again though. + OK - NA ? ISSUE ================================================================================= + Package meets naming and packaging guidelines + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. + Sources match upstream md5sum: [Ankur@localhost rpmbuild]$ md5sum ailurus-10.06.8.tar.gz 3eac90bab9fe03c53f5ce5ec067cc693 ailurus-10.06.8.tar.gz [Ankur@localhost rpmbuild]$ md5sum SOURCES/ailurus-10.06.8.tar.gz 3eac90bab9fe03c53f5ce5ec067cc693 SOURCES/ailurus-10.06.8.tar.gz - Package needs ExcludeArch + BuildRequires correct ? Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. + Package has a correct %clean section. + Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) ? Package is code or permissible content. - Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. + Package is a GUI app and has a .desktop file - Package compiles and builds on at least one arch. + Package has no duplicate files in %files. ? Package doesn't own any directories other packages own. ? Package owns all the directories it creates. ? No rpmlint output. SHOULD Items: + Should build in mock. + Should build on all supported archs + Should function as described. - Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version - check for outstanding bugs on package. (For core merge reviews) Issues: 1. Please use %find_lang for locale files https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files 2. I see a url.py with reference to repositories such as adobe and Rpmfusion. What exactly is the purpose of these? If these are used to configure these 3rd party repos, I'll have to confirm with legal if the package can be added into fedora. (otherwise we would have already had a nifty tool to set up Rpmfusion IMO) Please contact fedora-legal and get this clarified. 3. The files section needs some cleaning up. %{datadir}/icons -> %{datadir}/icons/* From: http://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#.25files_section " If you list a directory in the %files section, then you are claiming that this package owns that subdirectory and all files and directories in it, recursively (all the way down) if they are present in the build root" 4. rpmlint output is downright UGLY :P [Ankur@localhost SPECS]$ rpmlint ailurus.spec ../SRPMS/ailurus-10.06.8-0.fc13.src.rpm /var/lib/mock/fedora-rawhide-i386/result/*.rpm ailurus.src: W: summary-not-capitalized C makes Linux easier to use ailurus.src: W: invalid-url URL: http://ailurus.googlecode.com/ IncompleteRead(0 bytes read) ailurus.noarch: W: summary-not-capitalized C makes Linux easier to use ailurus.noarch: W: incoherent-version-in-changelog 10.06.8-1 ['10.06.8-0.fc14', '10.06.8-0'] ailurus.noarch: W: invalid-url URL: http://ailurus.googlecode.com/ IncompleteRead(0 bytes read) ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/info_pane.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/support/windowpos.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/ubuntu/libserver.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/support/terminal.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/gnome/__init__.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/ubuntu/quick_setup.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/loader.py 0644L /usr/bin/env ailurus.noarch: W: non-conffile-in-etc /etc/dbus-1/system.d/cn.ailurus.conf ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/strings.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/fedora/rpm_recovery_pane.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/ubuntu/tips.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/lib.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/gnome/osinfo.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/support/dump_apt_autoremovable.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/support/dump_rpm_existing.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/ubuntu/apps.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/support/dump_rpm_installed.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/support/terminal_single_thread.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/common/setting.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/clean_up_pane.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/common/hardwareinfo.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/fedora/apps_eclipse.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/ubuntu/app_from_external_repos.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/daemon.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/common/tips.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/support/dump_rpm_existing_new.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/support/dumpaptcache2.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/common/osinfo.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/ubuntu/__init__.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/fedora/cure.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/support/safely_deletable_pkgs.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/ubuntu/third_party_repos.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/support/searchbox.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/fedora/menu.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/common/__init__.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/support/tipoftheday.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/common/menu.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/gnome/setting.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/ubuntu/cure.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/libapp.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/fedora/apps.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/ubuntu/menu.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/libsetting.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/support/undobuffer.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/common/apps.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/urls.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/ubuntu/setting.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/support/keygrabber.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/computer_doctor_pane.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/fedora/fastest_mirror_pane.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/download_icons.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/install_remove_pane.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/gnome/apps.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/support/update_url.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/fedora/__init__.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/support/dump_deb_existing.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/support/dump_deb_installed.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/ubuntu/apps_eclipse.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/show_a_linux_skill_bubble.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/system_setting_pane.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/support/splashwindow.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/libu.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/common/cure.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/support/gdm_gconf.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/support/checkupdate.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/gnome/tips.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/main.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/ubuntu/fastest_mirror_pane.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/ubuntu/apt_recovery_pane.py 0644L /usr/bin/env ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/fedora/libserver.py 0644L /usr/bin/env ailurus.noarch: E: standard-dir-owned-by-package /usr/share/icons ailurus.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/ailurus/ubuntu/app_tasksel.py 0644L /usr/bin/env ailurus.noarch: W: file-not-in-%lang /usr/share/locale/ar/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/be/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/bg/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/bn/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/bs/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/ca/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/cs/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/da/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/de/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/el/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/en_AU/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/en_CA/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/en_GB/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/eo/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/es/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/fa/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/fi/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/fo/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/fr/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/ga/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/gl/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/he/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/hi/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/hu/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/id/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/is/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/it/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/ja/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/jv/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/ka/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/kk/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/ko/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/lt/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/mk/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/ml/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/ms/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/nb/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/nl/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/nn/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/oc/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/pl/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/pt/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/pt_BR/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/ro/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/ru/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/sk/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/sl/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/sq/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/sr/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/sv/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/te/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/th/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/tr/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/uk/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/vi/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/zh_CN/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/zh_HK/LC_MESSAGES/ailurus.mo ailurus.noarch: W: file-not-in-%lang /usr/share/locale/zh_TW/LC_MESSAGES/ailurus.mo ailurus.src: W: summary-not-capitalized C makes Linux easier to use ailurus.src: W: invalid-url URL: http://ailurus.googlecode.com/ IncompleteRead(0 bytes read) 3 packages and 1 specfiles checked; 71 errors, 66 warnings. 5. The summary could use some meat. "makes linux easier to use" isn't really telling the user anything. ================================================================================ Please look at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group regards, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review