Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=604501 Terje Røsten <terjeros@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |terjeros@xxxxxxxxxxxx Flag| |fedora-review? --- Comment #5 from Terje Røsten <terjeros@xxxxxxxxxxxx> 2010-07-11 05:48:57 EDT --- ok rpmlint ok named and versioned according to the Package Naming Guidelines ok spec file name matches base package name ok license : GPLv2+ tag correct and all files with license info ok COPYING packaged as %doc ok source matches upstream: dbea31f4092877e786fe040fae1374238fada94a gtk-chtheme-0.3.1.tar.bz2 dbea31f4092877e786fe040fae1374238fada94a gtk-chtheme-0.3.1.tar.bz2.1 ! builds in koji: something is wrong here, might be missing #include, please have a look. Ref: http://koji.fedoraproject.org/koji/taskinfo?taskID=2310790 http://koji.fedoraproject.org/koji/getfile?taskID=2310792&name=build.log ok no missing BuildRequires (builds in mock) ok no translations, so translation/locale guidelines don't apply ok no shared libraries, so no ldconfig calls neeed ok no duplicated system libraries ok package not relocatable ok directory ownership correct (doesn't own directories owned by another package, owns all package-specific directories) ok no duplicate files in %files ! permissions correct, defattr used correctly please drop %attr on man page, change to correct mode in %install. %attr is for special cases. ok macros ok no non-code content ok no large documentation files, so no -doc package needed ok no %doc files required at runtime ok no header files which would need to be in a -devel subpackage ok no static libraries, so no -static package needed ok no devel symlinks which would need to be in a -devel subpackage ok no -devel package, ok no .la files ok .desktop file ok desktop-file-validate is used in %install and the .desktop file passes validation ok all filenames are valid UTF-8 ok complies with the FHS ok proper changelog, tags, BuildRoot, BuildRequires, Summary, Description ok no macros in Summary and Description ok no non-UTF-8 characters ok all relevant documentation included as %doc ok RPM_OPT_FLAGS are used (%cmake macro) ok debuginfo package is valid ok no rpaths ok no configuration files, so %config guideline doesn't apply ok no init scripts, so init script guideline doesn't apply ok no timestamp-clobbering file commands ok _smp_mflags used ok not a web application, so web application guideline doesn't apply ok no conflicts Please have a look on items marked with ! . -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review