Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=612943 --- Comment #3 from Matthias Clasen <mclasen@xxxxxxxxxx> 2010-07-09 15:14:04 EDT --- package name: ok spec file name: ok packaging guidelines: ok, but if the package is only meant for F13+, then some cleanups are possible: - drop BuildRoot - drop initial rm -rf in %install - drop %clean section license: ok license file: ok license field: should be BSD, not GPLv2+ spec language: ok spec readable: yes upstream sources: ok buildable: ok ExcludeArch: ok BuildRequires: ok locale handling: ok ldconfig: ok system libraries: ok relocatable: ok directory ownership: ok duplicate files: ok file permissions: ok (pedants prefer the 4-argument form of %defattr) macro use: ok permissible content: ok large docs: ok %doc content: ok headers: ok (the wording of the guidelines is a bit unfortunate here...) static libs: ok shared libs: ok libtool archives: ok devel deps: ok gui apps: ok file ownership: ok utf8 filenames: ok Summary: - fix the license - apply minor cleanups at your discretion -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review