[Bug 612796] Review Request: python-ping - An implementation of the standard ICMP ping in pure Python.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=612796

Athmane Madjoudj <athmanem@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |athmanem@xxxxxxxxx

--- Comment #1 from Athmane Madjoudj <athmanem@xxxxxxxxx> 2010-07-09 13:49:32 EDT ---
rpmlint shows the following:

$ rpmlint python-ping-0.1-1.fc13.src.rpm 
python-ping.src: I: enchant-dictionary-not-found en_US
python-ping.src: W: summary-ended-with-dot C An implementation of the standard
ICMP ping in pure Python.
python-ping.src: E: no-changelogname-tag
python-ping.src:3: W: macro-in-comment %global
python-ping.src:3: W: macro-in-comment %{__python}
python-ping.src:44: W: macro-in-comment %{python_sitearch}
1 packages and 0 specfiles checked; 1 errors, 4 warnings.


$ rpmlint python-ping-0.1-1.fc13.src.rpm 
python-ping.src: I: enchant-dictionary-not-found en_US
python-ping.src: W: summary-ended-with-dot C An implementation of the standard
ICMP ping in pure Python.
python-ping.src: E: no-changelogname-tag
python-ping.src:3: W: macro-in-comment %global
python-ping.src:3: W: macro-in-comment %{__python}
python-ping.src:44: W: macro-in-comment %{python_sitearch}
1 packages and 0 specfiles checked; 1 errors, 4 warnings.


Proposed fixes:

[-] Try to cleanup all comments containing macros.
[-] Remove dot in Summary.
[-] Add the first Changelogs entry line, some thing like: - Initial package

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]